133 Add dynamic memory mgmt callbacks to host descriptors#141
133 Add dynamic memory mgmt callbacks to host descriptors#141jeronstone merged 21 commits intomainfrom
Conversation
…S/BSL into 133-mem-mgmt-callbacks
BrianSipos
left a comment
There was a problem hiding this comment.
Is there any value in segregating the four callbacks into a separate struct, have a full default replacement struct, and require in setter that they are all non-null? It might prevent an accidental "forgot to set one" situation by the BPA. But would not change the overall behavior.
I think I agree, it will make it cleaner. It is probably very unlikely a user will want to use custom callbacks for some, and defaults for others (and if a user really needs to, they can just set it manually to do so). I will make that update this evening. |
BrianSipos
left a comment
There was a problem hiding this comment.
I can make minor updates later today before approval
|



Closes #133